Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to 0.23.0 #73

Merged
merged 19 commits into from
Feb 20, 2024
Merged

Updating to 0.23.0 #73

merged 19 commits into from
Feb 20, 2024

Conversation

signorecello
Copy link
Collaborator

No description provided.

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2024 •
edited
Loading

✅ Deploy Preview for noir-vite-hardhat ready!

Name Link
🔨 Latest commit eef79bd
🔍 Latest deploy log https://app.netlify.com/sites/noir-vite-hardhat/deploys/65d3dd0e94534e0008d528aa
😎 Deploy Preview https://deploy-preview-73--noir-vite-hardhat.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@socket-security Socket Security
Copy link

socket-security bot commented Feb 12, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None +1 277 kB nicolo-ribaudo
npm/@lit-labs/[email protected] environment 0 35.7 kB lit-robot
npm/@motionone/[email protected] None +5 191 kB popmotion
npm/@motionone/[email protected] None +7 713 kB popmotion
npm/@motionone/[email protected] None 0 15.4 kB popmotion
npm/@motionone/[email protected] None +3 140 kB popmotion
npm/@noir-lang/[email protected] Transitive: environment, filesystem, network, shell +9 31.9 MB noir-lang
npm/@noir-lang/[email protected] Transitive: eval, filesystem, network +3 7.42 MB noir-lang
npm/@noir-lang/[email protected] None +1 29 MB noir-lang
npm/@noir-lang/[email protected] Transitive: filesystem, network +1 924 kB noir-lang
npm/@nomicfoundation/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +362 616 MB fvictorio
npm/@nomicfoundation/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +341 595 MB fvictorio
npm/@scure/[email protected] None 0 79.4 kB paulmillr
npm/@types/[email protected] None 0 95.6 kB types
npm/@types/[email protected] None +1 3.95 MB types
npm/@types/[email protected] None +3 1.68 MB types
npm/@vitejs/[email protected] filesystem, unsafe Transitive: environment, eval, network, shell +60 698 MB vitebot
npm/[email protected] None +9 678 kB vweevers
npm/[email protected] None 0 531 kB marijn
npm/[email protected] Transitive: eval +11 227 kB ljharb
npm/[email protected] None +7 923 kB keithamus
npm/[email protected] environment, filesystem +14 531 kB paulmillr
npm/[email protected] None 0 19.6 kB pi0
npm/[email protected] environment, filesystem 0 78.7 kB motdotla
npm/[email protected] network 0 29.4 kB rubenverborgh
npm/[email protected] eval +5 124 kB ljharb
npm/[email protected] Transitive: environment, network +13 2 MB pi0
npm/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +406 612 MB cgewecke
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +339 595 MB fvictorio
npm/[email protected] None +1 38.2 kB ljharb
npm/[email protected] None +2 72.8 kB ljharb
npm/[email protected] None +5 1.07 MB pi0
npm/[email protected] environment, eval, filesystem +66 4.94 MB joshuakgoldberg
npm/[email protected] network 0 749 kB pi0
npm/[email protected] environment, filesystem 0 13.4 kB mafintosh
npm/[email protected] None 0 30.8 kB pi0
npm/[email protected] None 0 1.37 MB jdecroock
npm/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +424 613 MB cgewecke
npm/[email protected] environment, filesystem, unsafe Transitive: shell +32 504 MB blakeembrey
npm/[email protected] filesystem Transitive: environment, unsafe +46 81.4 MB ethereum-ts-bot
npm/[email protected] None 0 97.8 kB pi0
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +46 267 MB vitebot
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +370 205 MB awkweb
npm/[email protected] Transitive: eval +16 348 kB ljharb

🚮 Removed packages: npm/@babel/[email protected], npm/@lit-labs/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@scure/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vitejs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

critesjosh
critesjosh requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually looks like I hit errors when interacting with the UI. You can see in the preview

critesjosh
critesjosh requested changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following error when running npx hardhat node and yarn test.
image
I comment out the accounts defined in hardhat.config.cts and it works, but it's not immediately clear that's what should be done, or if that's what should be done.

And I am still seeing this error when trying to run the UI.

image

@signorecello
Copy link
Collaborator Author

Yeah that error is actually fine, again it is trying to read from a view function without passing any params. I can try to see if there's any wagmi option to not fetch automatically.

The other error is weird because I thought I had removed these configs from hardhat config. I'll do it today and finally push this over the line

critesjosh
critesjosh requested changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have metamask installed and there was indication that I need to in the web app. Maybe just add a note to the README.

I installed it and still see this error, so it's still not working for me.
image

@signorecello
Copy link
Collaborator Author

So those logs aren't there anymore, I'm pretty sure you're getting a cached version of the page, or you didn't run yarn build in case you're running yarn preview. Can you double-check?

I'll change the README to make sure metamask is not mandatory

@signorecello signorecello merged commit a651a7e into main Feb 20, 2024
7 checks passed
@signorecello signorecello deleted the zpedro/0.23.0 branch February 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critesjosh critesjosh critesjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@signorecello @critesjosh @ludamad0